Skip to content

[GSK-1710] Added md suffix in pyproject #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 8, 2023
Merged

[GSK-1710] Added md suffix in pyproject #1392

merged 4 commits into from
Sep 8, 2023

Conversation

@rabah-khalek
Copy link
Contributor

@rabah-khalek rabah-khalek commented Sep 8, 2023

appending tool.setuptools.package-data with .md

@rabah-khalek rabah-khalek requested a review from mattbit September 8, 2023 14:26
@rabah-khalek rabah-khalek self-assigned this Sep 8, 2023
@linear
Copy link

linear bot commented Sep 8, 2023

GSK-1710 markdown templates to be included in pyproject.toml

currently,

scan_result.to_markdown()

gives:

jinja2.exceptions.TemplateNotFound: scan_report/markdown/github.md

@rabah-khalek rabah-khalek merged commit 9955229 into main Sep 8, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mattbit mattbit deleted the GSK-1710-markdown-templates-in-pyproject branch September 19, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattbit mattbit Awaiting requested review from mattbit

1 more reviewer

@andreybavt andreybavt andreybavt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rabah-khalek rabah-khalek

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rabah-khalek @andreybavt