[GSK-1700] Issue when df has single column #1385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabah-khalek
added
enhancement
GSK-1700 Single feature issue
if the dataframe contains only one column, this will cause problems: even if the feature is indicated in the this is due to the fact that an sklearn model expects 1D data to be a pd.Series instead of pd.DataFrame. |
andreybavt
suggested changes
Sep 7, 2023
| return self.data_preprocessing_function(data) | ||
|
|
||
| # In the case where a dataframe has one column, most sklearn models require a Series instead of a DataFrame. | ||
| # We check also the case of PredictionFunctionModel to be extra inclusive. |
Contributor
There was a problem hiding this comment.
@rabah-khalek could you add a unit test for it please?
andreybavt
approved these changes
Sep 14, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
rabah-khalek
added a commit
that referenced
this pull request
Sep 15, 2023
This reverts commit 84f15eb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the example is attached on the linear card.