Skip to content

Conversation

@Googleton
Copy link
Contributor

PR made on @kevinmessiaen's behalf to quickly merge it 🙏

@github-actions
Copy link

Please add the 'safe for build' label in order to perform the sonar analysis!

@Googleton
Copy link
Contributor Author

LGTM

# Conflicts:
#	backend/src/main/resources/config/liquibase/master.xml
# Conflicts:
#	backend/src/main/java/ai/giskard/service/SlicingFunctionService.java
#	backend/src/main/java/ai/giskard/service/TestFunctionService.java
#	backend/src/main/java/ai/giskard/service/TransformationFunctionService.java
#	backend/src/main/resources/config/liquibase/changelog/20230829180047_changelog.xml
#	backend/src/main/resources/config/liquibase/master.xml
Copy link
Contributor

@andreybavt andreybavt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, tested on tests and slicing functions (including rule based ones)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kevinmessiaen kevinmessiaen merged commit 97f01f8 into main Sep 6, 2023
@Hartorn Hartorn deleted the fix/lambda_upload_issue branch September 13, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants