Skip to content

Conversation

@henchaves
Copy link
Member

Description

This PR fixes the bug when the user manually change the data inputs back to the original ones, the Inspector keeps displaying a "modified" tag and the selector remains red ("dirty"). Now, if a user changes the input back to the original one, the form remains untouchable.

Related Issue

GSK-1567 (available on Linear)

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

@henchaves henchaves self-assigned this Aug 29, 2023
@linear
Copy link

linear bot commented Aug 29, 2023

@henchaves henchaves requested a review from Googleton August 29, 2023 09:37
@henchaves henchaves changed the title [GSK-1567] Fix detection if inputData equals originalData [GSK-1567] Modified button doesnt detect when user goes back to original value Aug 29, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@Googleton Googleton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! Good job

@Googleton Googleton merged commit 3f39893 into main Aug 31, 2023
@Hartorn Hartorn deleted the feature/gsk-1567-modified-button-doesnt-detect-when-user-goes-back-to branch September 13, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants