Skip to content

[GSK-1574] Add different background color to each filter button on Debugger #1327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 25, 2023
Merged

[GSK-1574] Add different background color to each filter button on Debugger #1327

merged 4 commits into from
Aug 25, 2023

Conversation

@henchaves
Copy link
Member

@henchaves henchaves commented Aug 23, 2023

Description

This PR adds a different background-color to each filter button on the Debugger tab. This can help the user to identify which filter is currently applied.

Related Issue

GSK-1574 (available on Linear)

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

@henchaves henchaves requested a review from Googleton August 23, 2023 12:15
@henchaves henchaves self-assigned this Aug 23, 2023
@linear
Copy link

linear bot commented Aug 23, 2023

GSK-1574 Change color if filter applied

@henchaves henchaves requested a review from AbSsEnT August 24, 2023 10:05
AbSsEnT
AbSsEnT approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@AbSsEnT AbSsEnT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is ok. Good job!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@henchaves henchaves merged commit 6aa73d7 into main Aug 25, 2023
@Hartorn Hartorn deleted the feature/gsk-1574-change-color-if-filter-applied branch September 13, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Googleton Googleton Awaiting requested review from Googleton

1 more reviewer

@AbSsEnT AbSsEnT AbSsEnT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@henchaves henchaves

Labels

Frontend

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@henchaves @AbSsEnT