Skip to content

[GSK-1593] Display Giskard Client info including URL, token and Spaces token #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Sep 15, 2023
Merged

[GSK-1593] Display Giskard Client info including URL, token and Spaces token #1324

merged 28 commits into from
Sep 15, 2023

Conversation

@Inokinoki
Copy link
Member

@Inokinoki Inokinoki commented Aug 22, 2023 •
edited
Loading

Description

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@linear
Copy link

linear bot commented Aug 22, 2023

GSK-1593 Giskard Client info for URL, token (App token+HF token)

Create a card called Giskard Client infos with

@github-actions
Copy link

Please add the 'safe for build' label in order to perform the sonar analysis!

@Inokinoki
Display generate button if MLWorker not connected
bfc035d 
Allow to regenerate token when HF access token is entered somewhere else
henchaves
henchaves requested changes Aug 25, 2023
View reviewed changes
kevinmessiaen
kevinmessiaen reviewed Aug 28, 2023
View reviewed changes
andreybavt
andreybavt suggested changes Sep 11, 2023
View reviewed changes
kevinmessiaen
kevinmessiaen reviewed Sep 15, 2023
View reviewed changes
Copy link
Member

@kevinmessiaen kevinmessiaen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a small typo

@Inokinoki Inokinoki self-assigned this Sep 15, 2023
@Inokinoki Inokinoki merged commit c21eec3 into main Sep 15, 2023
@Inokinoki Inokinoki deleted the feature/giskard-client-info branch September 15, 2023 09:07
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Googleton Googleton Awaiting requested review from Googleton

@henchaves henchaves Awaiting requested review from henchaves

@andreybavt andreybavt Awaiting requested review from andreybavt

@kevinmessiaen kevinmessiaen Awaiting requested review from kevinmessiaen

Assignees

@Inokinoki Inokinoki

Labels

Frontend safe for build

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Inokinoki @andreybavt @henchaves @kevinmessiaen