-
-
Notifications
You must be signed in to change notification settings - Fork 379
GSK-1554: Making comments for the dataset and model creation consistent across notebooks. #1322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
GSK-1554 Make example notebooks consistent with the Wrap Dataset page
In the documentation, in the 'quickstart' example we are using 'cat_columns' during Dataset creation. However another examples are mostly using 'column_types' during Dataset creation, without any comments, which confuses the user. We need to replace 'column_types' parameter by the 'cat_columns'. (and put the comments) This relates to the user-test with Princy: https://www.notion.so/giskard/4dbd310a5f854d608a3f54b502d1e5b8?v=68d5847ab02749e994f90a1271a6574f&p=3e445eca8e10475baa3868063ac5e4c5&pm=s |
|
Kudos, SonarCloud Quality Gate passed! |
|
LGTM. Despite of the metadata in Jupyter Notebook, I think the most common changes are to add the names of function argument and the comments, according to our docs, right? Could we add a title to conclude the changes in this PR? |
|
Done |








Making comments for the dataset and model creation consistent across notebooks.