Skip to content

[GSK-1549] fixed bug related to test execution #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2023
Merged

[GSK-1549] fixed bug related to test execution #1306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions python-client/giskard/ml_worker/testing/registry/giskard_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,9 +130,8 @@ def execute(self) -> Result:
analytics.track("test:execute", {"test_name": self.meta.full_name})

# if params contains debug then we check if test_fn has debug argument
if "debug" in self.params:
if "debug" not in list(inspect.signature(self.test_fn).parameters.keys()):
raise ValueError("This test does not support debugging mode at the moment.")
if "debug" in self.params and "debug" not in list(inspect.signature(self.test_fn).parameters.keys()):
self.params.pop("debug")

return self.test_fn(**self.params)

Expand Down