Skip to content

Conversation

@henchaves
Copy link
Member

Description

This PR aims to make it possible to create a new slicing function directly from the Catalog tab.

There will be an item on the Slicing Function list called "CREATE NEW SLICING FUNCTION".
Once clicked, it opens a modal with a form. On this form there will be radio buttons with possible scopes for a new slicing function:

  1. Specific dataset: The form will fetch columns from a specific dataset selected by user, so the user can choose a column.
  2. General: The form will ask for a generic string to be used as column name.

There will be two merges for this PR. The first one implements the "Specific dataset" scope, and the second one implements the "General" scope (because it may cause a lot of conflicts with #1175).

Related Issue

GSK-1540 (available on Linear)

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

@linear
Copy link

linear bot commented Aug 8, 2023

GSK-1540 Make it possible to create a Slicing Function directly from Catalog

Add a option to the list of Slicing Function called: "Create a new slicing function"

When clicked, open a Modal. This modal should contain three radio buttons: "Global", "Project", "Dataset"

  • Dataset: the slicing function will use a specific column (DatasetSelector + ColumnFilterCreator)
  • General: the slicing function will use a string as column (text input - clone ColumnFilterCreator but without dataset as prop)

@henchaves henchaves self-assigned this Aug 8, 2023
@henchaves henchaves marked this pull request as ready for review August 10, 2023 14:31
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@henchaves henchaves merged commit fd5bcee into main Aug 16, 2023
@Hartorn Hartorn deleted the feature/gsk-1540-make-it-possible-to-create-a-slicing-function-directly-from branch September 13, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants