- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 377
 
[GSK-1506] Update code snippet for pickled testfunction and its default values #1304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSK-1506] Update code snippet for pickled testfunction and its default values #1304
Conversation
          GSK-1506 Code snippet for pickled function (and default values) does not work
 When I open a pickled function ( It should be:  | 
    
…nction-and-default-values-does
…nction-and-default-values-does
…nction-and-default-values-does
…nction-and-default-values-does
…nction-and-default-values-does
…nction-and-default-values-does
| .value() | ||
| .filter(i => i !== 'str'), | ||
| selected.value.name | ||
| .filter(i => i !== 'str') | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we should ignore any primitives (int, float, 'str, bool, ...).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Furthermore we also only need to import when the default value is set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Furthermore we also only need to import when the default value is set
The line 196 creates an array of only required params
…nction-and-default-values-does
…nction-and-default-values-does
…nction-and-default-values-does
…nction-and-default-values-does
| 
           Kudos, SonarCloud Quality Gate passed!      | 
    








Description
This PR aims to fix the code snippet displayed for a custom testing function.
Basically, we must provide to user the code to instantiate
GiskardClientand download the testing function.Also, we should provide the code to download a slicing function/transformation function if they are linked to the given testing function.
Related Issue
GSK-1506 (available on Linear)
Type of Change