[GSK-1316, GSK-1415] Spurious Correlation tests #1302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabah-khalek
changed the title
mattbit
requested changes
Aug 7, 2023
There was a problem hiding this comment.
- Decide if it’s better to have a single
test_nominal_associationwith different methods (could be easier to understand for the user) or specific tests for each metric liketest_theil_u(this would be for power users I would say) or both. - Small refactoring of code to use a common
_test_associationwith the different methods (internal) - Add tests!
Comment on lines
413
to
440
| import pandas as pd | ||
|
|
||
| sliced_dataset = dataset.slice(slicing_function) | ||
| check_slice_not_empty(sliced_dataset=sliced_dataset, dataset_name="dataset", test_name="test_theil_u") | ||
|
|
||
| dx = pd.DataFrame( | ||
| { | ||
| "slice": dataset.df.index.isin(sliced_dataset.df.index).astype(int), | ||
| "prediction": model.predict(dataset).prediction, | ||
| }, | ||
| index=dataset.df.index, | ||
| ) | ||
| dx.dropna(inplace=True) | ||
|
|
||
| metric = _theil_u(dx.slice, dx.prediction) | ||
| passed = metric < threshold | ||
|
|
||
| # --- debug --- | ||
| output_ds = None | ||
| if not passed and debug: | ||
| output_ds = sliced_dataset.copy() # copy all properties | ||
| test_name = inspect.stack()[0][3] | ||
| output_ds.name = debug_prefix + test_name | ||
| # --- | ||
|
|
||
| messages = [TestMessage(type=TestMessageLevel.INFO, text=f"metric = {metric}, threshold = {threshold}")] | ||
|
|
||
| return TestResult(metric=metric, passed=passed, messages=messages, output_df=output_ds) |
There was a problem hiding this comment.
The only difference with the previous test is that we call _teil_u instead of _mutual_information. This could be refactored in a single test_nominal_association with a method attribute for example (e.g. theil or mutual_info) to avoid code repetition.
mattbit
approved these changes
Aug 7, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Titanic scan:
Todo: write docstrings