Skip to content

Fix automatic Docker image building with mono-image #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Sep 8, 2023
Merged

Fix automatic Docker image building with mono-image #1297

merged 23 commits into from
Sep 8, 2023

Conversation

@Inokinoki
Copy link
Member

Description

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@Inokinoki Inokinoki marked this pull request as draft August 4, 2023 10:20
@Inokinoki Inokinoki changed the title [Draft] Build singleimage for Backend, Frontend and MLWorker [Draft] Build single image for Backend, Frontend and MLWorker Aug 4, 2023
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Please add the 'safe for build' label in order to perform the sonar analysis!

@Inokinoki Inokinoki marked this pull request as ready for review August 10, 2023 16:27
@Inokinoki Inokinoki changed the title [Draft] Build single image for Backend, Frontend and MLWorker Fix automate Docker image building with a single Docker image for Backend, Frontend and MLWorker Aug 10, 2023
@Inokinoki Inokinoki changed the title Fix automate Docker image building with a single Docker image for Backend, Frontend and MLWorker Fix automatic Docker image building with a single Docker image for Backend, Frontend and MLWorker Aug 10, 2023
@Inokinoki Inokinoki changed the title Fix automatic Docker image building with a single Docker image for Backend, Frontend and MLWorker Fix automatic Docker image building with a single image for Backend, Frontend and MLWorker Aug 10, 2023
@Inokinoki
Copy link
Member Author

After merging, devs are again able to trigger build-images action to upload test Docker image.
E.g., the image for this branch is at: https://hub.docker.com/layers/giskardai/giskard/fix-docker-build-monoimage/images/sha256-ac707b5a582b98057b86b22db829399ece1d0dc6b09b1317b938d20570e219f0

kevinmessiaen
kevinmessiaen reviewed Aug 31, 2023
View reviewed changes
andreybavt
andreybavt suggested changes Sep 1, 2023
View reviewed changes
@Inokinoki Inokinoki changed the title Fix automatic Docker image building with a single image for Backend, Frontend and MLWorker Fix automatic Docker image building with mono-image Sep 4, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

andreybavt
andreybavt suggested changes Sep 4, 2023
View reviewed changes
@Inokinoki Inokinoki merged commit 7280f58 into main Sep 8, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Hartorn Hartorn deleted the fix-docker-build-monoimage branch September 22, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinmessiaen kevinmessiaen kevinmessiaen left review comments

+1 more reviewer

@andreybavt andreybavt andreybavt requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

safe for build

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Inokinoki @andreybavt @kevinmessiaen