Skip to content

[GSK-1476] introducing debug_description in test decorator #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 36 commits into from
Sep 28, 2023
Merged

[GSK-1476] introducing debug_description in test decorator #1290

merged 36 commits into from
Sep 28, 2023

Conversation

@rabah-khalek
Copy link
Contributor

@rabah-khalek rabah-khalek commented Aug 2, 2023

The idea is to describe what the debug does for every test when a user clicks on the button

@linear
Copy link

linear bot commented Aug 2, 2023

GSK-1476 Add a debug dataset description to the @test decorator to show it in the dialog when a user clicks on debug

@rabah-khalek rabah-khalek marked this pull request as draft August 2, 2023 14:45
@rabah-khalek
Copy link
Contributor Author

rabah-khalek commented Aug 2, 2023

@Googleton, I introduced the default message, What's left is to propagate it for every test with a custom message.
Could you please test if you can retrieve it on the UI without any issues? I created the DTOs but just want to be sure I haven't forgotten anything. Thanks!

@rabah-khalek rabah-khalek added Python Pull requests that update Python code Frontend Backend labels Aug 2, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

57.1% 57.1% Coverage
0.0% 0.0% Duplication

@Inokinoki Inokinoki self-assigned this Sep 14, 2023
@Inokinoki Inokinoki marked this pull request as ready for review September 18, 2023 09:55
@Inokinoki
Copy link
Member

Inokinoki commented Sep 18, 2023

Preview:

image

@Inokinoki
Copy link
Member

Inokinoki commented Sep 19, 2023

Preview:

image

Updated:
image

Inokinoki and others added 6 commits September 19, 2023 19:03
@Inokinoki
Merge branch 'main' of https://github.com/Giskard-AI/giskard into GSK…
a80d34f 
…-1476-debug-description
@rabah-khalek
Merge branch 'main' into GSK-1476-debug-description
6d01477
@rabah-khalek
[GSK-1715] Filling per-test debug descriptions (#1412)
abea382 
* performance

* adjusted bold rendering

* added bold to default message

* statistic

* metamorhpic

* drift

* calibration

* adjusted frontend

* implemented @jmsquare's feedback

* fixed tests
@rabah-khalek
solving [GSK-1768]
05e9ba8
@rabah-khalek
silenced sonar
5c64a68
@rabah-khalek
silenced sonar
cc84579
@Inokinoki Inokinoki requested a review from Googleton September 26, 2023 15:39
Inokinoki
Inokinoki approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@Inokinoki Inokinoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @rabah-khalek for the debug description messages!
Could you plz test to start a new instance without existing DB from main and connect an internal ML worker (so that the test function does not contain debug description), and then restart both DB and worker from this branch, to see whether the debug descriptions are updated or not.
I tested locally, it seems to be working now.

@rabah-khalek
Copy link
Contributor Author

rabah-khalek commented Sep 27, 2023

@Inokinoki @Googleton the backend build seems to be failing, could you please have a look? I hope it's an easy fix.

@Inokinoki
Copy link
Member

Inokinoki commented Sep 27, 2023

@Inokinoki @Googleton the backend build seems to be failing, could you please have a look? I hope it's an easy fix.

Checked, it seems to be random network issue in the last CI. This one passes

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@rabah-khalek rabah-khalek merged commit 04455a6 into main Sep 28, 2023
@rabah-khalek rabah-khalek deleted the GSK-1476-debug-description branch September 28, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Inokinoki Inokinoki Inokinoki approved these changes

@andreybavt andreybavt Awaiting requested review from andreybavt

+1 more reviewer

@Googleton Googleton Googleton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Inokinoki Inokinoki

@rabah-khalek rabah-khalek

Labels

Backend Frontend Python Pull requests that update Python code

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rabah-khalek @Inokinoki @Googleton @andreybavt