Skip to content

Create CONTRIBUTING.md #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 10, 2022
Merged

Create CONTRIBUTING.md #129

merged 3 commits into from
Jul 10, 2022

Conversation

@jmsquare
Copy link
Member

@jmsquare jmsquare commented Jul 4, 2022 •
edited by alexcombessie
Loading

Description

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@jmsquare jmsquare requested a review from alexcombessie July 4, 2022 06:08
alexcombessie
alexcombessie suggested changes Jul 4, 2022
View reviewed changes
jmsquare added 2 commits July 10, 2022 15:27
@jmsquare
Merge branch 'main' into jmsquare-contributing
9e677d9
@jmsquare
V2 from JM
3a1c6e7 
New version that takes into account Alex comments
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jmsquare jmsquare requested a review from alexcombessie July 10, 2022 13:46
@alexcombessie
Copy link
Member

alexcombessie commented Jul 10, 2022

Awesome, thanks @jmsquare ! I let you merge 👍

For the topic on what issue tracker we should use to facilitate contribution, do you want to start a Github discussion?

@alexcombessie alexcombessie merged commit ce953ef into main Jul 10, 2022
@Hartorn Hartorn deleted the jmsquare-contributing branch September 13, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alexcombessie alexcombessie alexcombessie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmsquare jmsquare

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmsquare @alexcombessie