Skip to content

Conversation

@henchaves
Copy link
Member

Description

This PR aims to fix a bug on UI, which happens when a user clicks to verify an inspection linked to the target dataset to be deleted.

Related Issue

GSK-1437 (available on Linear)

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

@henchaves henchaves self-assigned this Jul 26, 2023
@linear
Copy link

linear bot commented Jul 26, 2023

GSK-1437 Fix Dataset unexpectedly delete

a0cebefe-9bd8-40e4-9622-77ff478c6715

If there is a feedback related to a dataset, when clicking to Delete this dataset will display the feedback it's linked.

Then, if we click to open this feedback (without clicking to confirm delete), this will delete the dataset and try to open the given feedback.

@henchaves henchaves requested a review from kevinmessiaen August 1, 2023 16:06
@kevinmessiaen kevinmessiaen merged commit c0d4765 into main Aug 2, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Hartorn Hartorn deleted the feature/gsk-1437-fix-dataset-unexpectedly-delete branch September 13, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants