Skip to content

[GSK-1440] Retrieve JWT from local storage before connecting #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 23, 2023
Merged

[GSK-1440] Retrieve JWT from local storage before connecting #1249

merged 5 commits into from
Aug 23, 2023

Conversation

@Inokinoki
Copy link
Member

Description

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@linear
Copy link

linear bot commented Jul 19, 2023

GSK-1440 Failed WebSocket connection after and infinite retry

Issue Type

Bug

Source

source

Giskard Library Version

2.0.0b10

Giskard Server Version

2.0.0b10

OS Platform and Distribution

No response

Python version

No response

Installed python packages

No response

Current Behaviour?

WebSocket connection keeps failed after JWT expiration.

Error info:

ERROR
message:Failed to send message to ExecutorSubscribableChannel[clientInboundChannel]; nested exception is io.jsonwebtoken.ExpiredJwtException\c JWT expired at 2023-07-19T18\c42\c02Z. Current time\c 2023-07-19T18\c42\c48Z, a difference of 46285 milliseconds.  Allowed clock skew\c 0 milliseconds.
content-length:0



### Standalone code OR list down the steps to reproduce the issue

```shell
1. Open frontend and login
2. Wait for JWT expiration (or manually expire it)
3. Do not refresh the frontend, and restart the Backend
4. After re-login, the WebSocket connection cannot be established using the previous JWT, which is acquired during the first login

Relevant log output

No response

@github-actions
Copy link

Please add the 'safe for build' label in order to perform the sonar analysis!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Inokinoki Inokinoki merged commit b08e3ed into main Aug 23, 2023
@Inokinoki
Copy link
Member Author

Inokinoki commented Aug 30, 2023 •
edited
Loading

Closed #1248

@Hartorn Hartorn deleted the fix/websocket-reconnect-jwt-expiration branch September 22, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henchaves henchaves henchaves approved these changes

@Googleton Googleton Awaiting requested review from Googleton

Assignees

@Inokinoki Inokinoki

Labels

Frontend safe for build

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Inokinoki @henchaves