[GSK-1289] UI issue incorrect colour of correctly predicted labels #1231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSK-1289 UI issue. Incorrect colour of correctly predicted labels.
Pay attention on the "Prediction" zone. When samples changed from correctly predicted to incorrectly, colour is switched from green to red too early. |
henchaves
changed the title
…ssue-incorrect-colour-of-correctly-predicted-labels # Conflicts: # frontend/src/views/main/project/Inspector.vue
…f-correctly-predicted-labels
| const errorLoadingMetadata = ref("") | ||
| const dataErrorMsg = ref("") | ||
| const classificationResult = ref("") | ||
| const debouncingTimeout = ref(500); |
There was a problem hiding this comment.
This can be a constant since its immutable const debouncingTimeout = 500
There was a problem hiding this comment.
It's true, I forgot to convert it as a constant when migrating
…ssue-incorrect-colour-of-correctly-predicted-labels # Conflicts: # frontend/src/views/main/project/Inspector.vue
Co-authored-by: Kevin Messiaen <[email protected]>
kevinmessiaen
approved these changes
Jul 10, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Hartorn
deleted the
feature/gsk-1289-ui-issue-incorrect-colour-of-correctly-predicted-labels
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix the UI on the Debugger tab when changing from one instance to another. The actual value was changing before modifying the colour. Now, all results will be forced to be rendered again.
Also, a few components were migrated to Composition API in this PR:
PredictionResults.vueInspector.vueResultPopover.vueRelated Issue
GSK-1289 (available on Linear)
Type of Change