Skip to content

Conversation

@kevinmessiaen
Copy link
Member

Description

Global argument of a test suite take priority on test argument

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@linear
Copy link

linear bot commented Jun 30, 2023

GSK-1340 Parameters passed to `test_suite.run` do not seem to overwrite tests local parameters

Andrey said:

you can specify arguments in the suite.run(…)  the args you pass at suite level will take precedence over “fixed” arguments in the tests

This does not seem to be the case.

@kevinmessiaen kevinmessiaen marked this pull request as ready for review June 30, 2023 07:51
@kevinmessiaen kevinmessiaen merged commit fad0070 into main Jun 30, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Hartorn Hartorn deleted the feature/gsk-1340-parameters-passed-to-test_suiterun-do-not-seem-to-overwrite branch September 13, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants