-
-
Notifications
You must be signed in to change notification settings - Fork 379
[GSK-1384] Fix internal worker exception due to artifact logging #1212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add the 'safe for build' label in order to perform the sonar analysis! |
Member
Author
|
Do not hesitate if there is any suggestions, in both code and codestyle. |
GSK-1384 Internal worker exception during model inspection
Issue TypeBug Sourcesource Giskard Library Version2.0.0b10 Giskard Server Version2.0.0b10 OS Platform and DistributionmacOS 13.4.1 Python version3.9.6 Installed python packagesCurrent Behaviour?Relevant log output |
Member
Author
Member
Author
|
Kudos, SonarCloud Quality Gate passed! |
andreybavt
approved these changes
Jul 3, 2023
This was referenced Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.








Description
In an internal worker, log the artifacts in the local Giskard home. Server is able to locate them and provides them to the frontend.
Although this is not a common case in Giskard 2.0 anymore, because only external workers can run models and log the artifacts. However, this fixes the inspections of some inherited projects from the previous version, with
mlWorkerType == MLWorkerType.INTERNAL.In the frontend, the
dataset.categoryFeaturecould benullfor some reasons. A simple check is also performed before using it inInspector.Related Issue
Type of Change
Checklist
CODE_OF_CONDUCT.mddocument.CONTRIBUTING.mdguide.make codestyle.