Skip to content

GSK-1105 & GSK-1132: create some basic methods to the test suite #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Sep 1, 2023
Merged

GSK-1105 & GSK-1132: create some basic methods to the test suite #1208

merged 16 commits into from
Sep 1, 2023

Conversation

@kevinmessiaen
Copy link
Member

@kevinmessiaen kevinmessiaen commented Jun 27, 2023 •
edited
Loading

Description

  • Added a method to remove tests
  • Added a method to update tests
  • Added a method to download the test suite

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@linear
Copy link

linear bot commented Jun 27, 2023

GSK-1132 Create some basic methods to the test suite

  • remove test from a test suite
  • customize a test from a test suite : change an argument

@kevinmessiaen kevinmessiaen changed the title Feature/gsk 1132 create some basic methods to the test suite GSK-1105 & GSK-1132: create some basic methods to the test suite Jun 28, 2023
@linear
Copy link

linear bot commented Jun 28, 2023

GSK-1105 Allow to download test suite 

suite = Suite.download(giskard_client, suite_uuid)

@kevinmessiaen kevinmessiaen marked this pull request as ready for review June 30, 2023 08:41
rabah-khalek
rabah-khalek reviewed Jun 30, 2023
View reviewed changes
@kevinmessiaen kevinmessiaen force-pushed the feature/gsk-1132-create-some-basic-methods-to-the-test-suite branch from 6091e2d to a0629a6 Compare July 7, 2023 03:00
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

51.5% 51.5% Coverage
0.0% 0.0% Duplication

@rabah-khalek rabah-khalek added Python Pull requests that update Python code Backend labels Jul 28, 2023
@andreybavt andreybavt requested a review from Inokinoki August 31, 2023 22:26
@andreybavt
Merge branch 'main' into feature/gsk-1132-create-some-basic-methods-t…
0327803 
…o-the-test-suite

# Conflicts:
#	python-client/giskard/core/suite.py
#	python-client/tests/test_programmatic.py
@andreybavt
fix formatting
fce8552
andreybavt
andreybavt approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@andreybavt andreybavt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

48.8% 48.8% Coverage
0.0% 0.0% Duplication

@kevinmessiaen kevinmessiaen merged commit 8b3684e into main Sep 1, 2023
@Hartorn Hartorn deleted the feature/gsk-1132-create-some-basic-methods-to-the-test-suite branch September 13, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Inokinoki Inokinoki Awaiting requested review from Inokinoki

2 more reviewers

@rabah-khalek rabah-khalek rabah-khalek left review comments

@andreybavt andreybavt andreybavt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Backend Python Pull requests that update Python code

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kevinmessiaen @andreybavt @rabah-khalek