Feature/gsk 1243 project export doesnt work

[kevinmessiaen]

Description

• Fixed recursive issues
• Export tests/slicing/transformation
• Fix issue with parameters

Related Issue

Type of Change

• 📚 Examples / docs / tutorials / dependencies update
• 🔧 Bug fix (non-breaking change which fixes an issue)
• 🥂 Improvement (non-breaking change which improves an existing feature)
• 🚀 New feature (non-breaking change which adds functionality)
• 💥 Breaking change (fix or feature that would cause existing functionality to change)
• 🔐 Security fix

Checklist

• I've read the CODE_OF_CONDUCT.md document.
• I've read the CONTRIBUTING.md guide.
• I've updated the code style using make codestyle.
• I've written tests for all new methods and classes that I created.
• I've written the docstring in Google format for all the methods and classes that I used.

[linear]

GSK-1243 Project export doesn't work

• Follow german credit scorring notebook
• after test suite upload export the project

giskard-diagnose-2_0_0b2-20230606_220437_713668.tar.gz

[Inokinoki]

Is this still WIP?

I could review if it's ready and up-to-date

[kevinmessiaen]

@Inokinoki This PR needs to be updated with main, the export might be broken due to modification of database schema. It was initially on hold due to ongoing refactor of artifacts but we can merge it.

[kevinmessiaen]

@Inokinoki I've updated the branch and the export seems to be working with latest modification

[Inokinoki]

LGTM
Tested locally, working perfectly!

Could the 5 code smells in SonarLint be fixed as well?

In addition, should we display something like "export failed" when getting 500 in frontend side? I can add it if you do not have time

[Inokinoki]

I tried to improve the code smell stuff from SonarLint. But I am not sure how to implement the comparison in the remaining one.
Could @kevinmessiaen please review them?

[kevinmessiaen]

I tried to improve the code smell stuff from SonarLint. But I am not sure how to implement the comparison in the remaining one. Could @kevinmessiaen please review them?

Sure I fixed the error. In this case we had to override it to make sure two instance of Callable with same uuid but a different class (eg. SlicingFunction and TransformationFunction) are not interpreted has equals.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[Inokinoki]

LGTM