-
-
Notifications
You must be signed in to change notification settings - Fork 377
GSK-1335 & GSK-1264 & GSK-1255 - Test re-execution result not clear #1196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GSK-1335 & GSK-1264 & GSK-1255 - Test re-execution result not clear #1196
Conversation
GSK-1335 Bug with re-execution of test
branch: feature/debug_output description: I find new bug. IfI want to re-run the test with the same or new parameters, without updating a page, I cannot get result message. In the terminal I see, that the test is executed, but no result is shown: |
GSK-1255 Add the possibility to run tests on whole dataset from catalog
Currently we run test from catalog on dataset sample, we want to have a dropdown menu to run on whole dataset (as in test suite execution modal) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't checked the code, but I have tested it, and it does exactly what it says on the tin.
| async getCatalog(projectId: number) { | ||
| return apiV2.get<unknown, CatalogDTO>(`/catalog`, { | ||
| params: { | ||
| projectId, | ||
| }, | ||
| projectId | ||
| } | ||
| }); | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't we use projectId as a path param?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's true that it also can be a path variable in this case. I think it was set as a filter to show the data associated to the project but now that all catalog items will be linked to projects it make more sense to use a path variable.
Let me change it in #1175 since it's a PR that heavily refacto the catalog
|
Kudos, SonarCloud Quality Gate passed! |








Description
Type of Change