Skip to content

Conversation

@rabah-khalek
Copy link
Contributor

fixes: https://linear.app/giskard/issue/GSK-1274/giskarddemotitanic-is-broken

I refactored titanic classification and linear regression demos, keeping in __init__.py only the factory methods (without breaking our docs).

@rabah-khalek rabah-khalek requested a review from andreybavt June 19, 2023 10:27
@rabah-khalek rabah-khalek self-assigned this Jun 19, 2023
@linear
Copy link

linear bot commented Jun 19, 2023

GSK-1274 giskard.demo.titanic() is broken

  • it’s because titanic() is in demo.__init__.py- which is not a very good practice, init code should be reserved for import, not actual business logic
  • And demo isn’t part of _all_ in  giskard.__init__.py

@rabah-khalek rabah-khalek changed the title Refactoring of demo [GSK-1274] Refactoring of demo Jun 19, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

68.3% 68.3% Coverage
0.0% 0.0% Duplication

@andreybavt andreybavt merged commit 064bfb4 into main Jun 21, 2023
@Hartorn Hartorn deleted the task/gsk-1274 branch September 13, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants