fix: dataset.create_test_case does not filter out attributes #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g behavior - Add parameterized test for Dataset.create_chat_test_case to ensure extra fields (e.g., id/timestamps) from imported ChatTestCase objects are not forwarded. - Cover both inputs: - plain ChatTestCase constructed in-code - imported ChatTestCase via from_dict with id/timestamps - Document SimpleNamespace usage for lightweight client wiring.
Hartorn
changed the title
- Send only allowed fields (messages, demo_output, tags, checks) plus dataset_id instead of forwarding the full ChatTestCase dict (which included id/timestamps). - Prevents TypeError when creating test cases from objects copied across environments.
|
henchaves
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.