feat: remove CSV support for knowledge base creation #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove document_column and topic_column parameters from knowledge base create method - Update validation to only allow JSON/JSONL files for knowledge bases - Remove CSV test case from knowledge base tests - Update documentation to remove CSV references for knowledge bases - Preserve CSV functionality for chat test cases/datasets Breaking changes: - Knowledge base create method no longer accepts column parameters - Only JSON/JSONL files supported for knowledge base creation
- Restore CSV documentation for dataset imports (was incorrectly removed) - Remove CSV format references from knowledge base UI documentation only - Preserve CSV functionality for datasets while removing it for knowledge bases
- Update KnowledgeBasesResource.create() to accept column parameters - Add document_column and topic_column with defaults "text" and "topic" - Update method documentation to reflect new parameters
henchaves
approved these changes
Sep 19, 2025
- KnowledgeBasesResource.create: use Union[str, NotGiven] for document_column and topic_column - Send column params only when explicitly provided (filter_not_given) - Restore test_create_with_csv_file_error to ensure CSV input is rejected - Keep description typing unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes: