-
Notifications
You must be signed in to change notification settings - Fork 1
chore(api): [GSK-4308] Rename any Conversation mention to ChatTestCase #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(api): [GSK-4308] Rename any Conversation mention to ChatTestCase #52
Conversation
|
hey @Inokinoki, it seems very good :) could you just also add some tests like:
|
Hey, during adding the tests, I found that the checks don't seem to have the right type after It's still dict while we are expecting Is this something wrong? How should we process them if so, will anything break if we also fix it here? |
…/gsk-4308-rename-any-conversation-mention-to-chattestcase-testcase
To be fixed in https://github.com/Giskard-AI/giskard-hub/compare/feature/gsk-4163-add-missing-resources |
…/gsk-4308-rename-any-conversation-mention-to-chattestcase-testcase
…/gsk-4308-rename-any-conversation-mention-to-chattestcase-testcase
Co-authored-by: Henrique Chaves <[email protected]>
Co-authored-by: Henrique Chaves <[email protected]>
Co-authored-by: Henrique Chaves <[email protected]>
Co-authored-by: Henrique Chaves <[email protected]>
|
Thanks @henchaves for discovering the URLs that we have already changed |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me! Thanks for all the hard work, @Inokinoki



Main points:
ChatTestCasesResourceandChatTestCasedata classchat_test_caseorconversationfrom the evaluation results to ensure compatibility