chore: add CI workflow #46
Conversation
There was a problem hiding this comment.
we could add timeout limit in both jobs
There was a problem hiding this comment.
I don't think it's useful in this case.
What do you have in mind ?
There was a problem hiding this comment.
to avoid any job hanging for 6 hours,
we could add timeout-minutes: 30
https://stackoverflow.com/questions/59073731/set-default-timeout-on-github-action-pipeline
| run: make doc | ||
|
|
||
| test: | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
should also run in other platforms such as macos and windows, no?
There was a problem hiding this comment.
It should not matter, we don't use complex lib or math lib
| strategy: | ||
| fail-fast: false # Do not stop when any job fails | ||
| matrix: | ||
| python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"] |
There was a problem hiding this comment.
add a TODO to remove 3.9 support after October 2025
There was a problem hiding this comment.
We'll remove it when we drop the support, added in a linear card
src/giskard_hub/_base_client.py
Outdated
| except httpx.HTTPStatusError as e: | ||
| if e.response.status_code == httpx.codes.UNPROCESSABLE_ENTITY: | ||
| raise ValueError("Validation error: " + e.response.text) | ||
| raise ValueError("Validation error: " + e.response.text) from e |
There was a problem hiding this comment.
out of scope, should be handled in #44
There was a problem hiding this comment.
it's to fix the linting, but you want, I can drop this
There was a problem hiding this comment.
You mean why not using [] as a default ?
This object would be a reference to an list, so the same list would be used for every calls
|
No description provided.