Skip to content

chore: [ENG-1038/ENG-1046] Refactor ScansResource methods #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 22, 2025
Merged

chore: [ENG-1038/ENG-1046] Refactor ScansResource methods #115

merged 3 commits into from
Oct 22, 2025

Conversation

@henchaves
Copy link
Member

@henchaves henchaves commented Oct 20, 2025

This PR does two things in ScansResource:

  • Fetch scan categories directly from the Hub API instead of using local values
  • Remove data check of tags when launching a scan (this was necessary before to avoid a bug)

⚠️ THIS PR MUST BE MERGED ONLY AFTER HUB PRs #1085 AND #1093 ⚠️

@henchaves henchaves self-assigned this Oct 20, 2025
@linear
Copy link

linear bot commented Oct 20, 2025

ENG-1038 BUG: Scan launch fails with tags=None and misbehaves with tags=[]

ENG-1046 Scan categories: backend source consumed by frontend and Giskard Hub

kevinmessiaen
kevinmessiaen approved these changes Oct 21, 2025
View reviewed changes
Copy link
Member

@kevinmessiaen kevinmessiaen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a quick suggestion

src/giskard_hub/data/scan.py
)

category_map = {cat.id: cat.title for cat in SCAN_CATEGORIES}
category_map = {
Copy link
Member

@kevinmessiaen kevinmessiaen Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we cache this?

Copy link
Member Author

@henchaves henchaves Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 21, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@henchaves henchaves merged commit e484bff into main Oct 22, 2025
15 checks passed
@henchaves henchaves deleted the chore/refactor-scans-resource-methods branch October 22, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinmessiaen kevinmessiaen kevinmessiaen approved these changes

Assignees

@henchaves henchaves

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@henchaves @kevinmessiaen