Skip to content

[Fix]Speaker toggling uncontrolably #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2025
Merged

[Fix]Speaker toggling uncontrolably #968

merged 2 commits into from
Oct 13, 2025

Conversation

@ipavlidakis
Copy link
Contributor

@ipavlidakis ipavlidakis commented Oct 13, 2025 •
edited
Loading

🔗 Issue Links

Resolves https://linear.app/stream/issue/IOS-1098/speaker-constantly-toggling-onoff

📝 Summary

This revision attempts to fix the long-standing issue of audio output by using the .voiceChat AVAudioSession.Mode and skipping .videoChat.

🧪 Manual Testing Notes

  • Join various calls (ringing and not) and ensure that speaker works as intended across all states of those calls

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (tutorial, CMS)

@ipavlidakis ipavlidakis self-assigned this Oct 13, 2025
@ipavlidakis ipavlidakis requested a review from a team as a code owner October 13, 2025 12:18
@ipavlidakis ipavlidakis added the bug Something isn't working label Oct 13, 2025
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Oct 13, 2025 •
edited
Loading

SDK Size

title develop branch diff status
StreamVideo 8.67 MB 8.67 MB 0 KB 🟢
StreamVideoSwiftUI 2.36 MB 2.36 MB 0 KB 🟢
StreamVideoUIKit 2.48 MB 2.48 MB 0 KB 🟢
StreamWebRTC 11.01 MB 11.01 MB 0 KB 🟢

@github-actions
Copy link

github-actions bot commented Oct 13, 2025

Public Interface

🚀 No changes affecting the public interface.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 13, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ipavlidakis ipavlidakis merged commit 80705fb into develop Oct 13, 2025
20 of 21 checks passed
@ipavlidakis ipavlidakis deleted the fix/speaker-toggling-uncontrollably branch October 13, 2025 14:15
This was referenced Oct 13, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees

@ipavlidakis ipavlidakis

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ipavlidakis @Stream-SDK-Bot @martinmitrevski