[Performance]Timers improvements #877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Public Interface+ public struct DefaultTimer: Timer
+
+ public static func publish(every interval: TimeInterval)-> AnyPublisher<Date, Never>
|
Generated by 🚫 Danger |
Collaborator
SDK Size
|
Public Interface+ public struct DefaultTimer: Timer
+
+ public static func publish(every interval: TimeInterval,file: StaticString = #file,function: StaticString = #function,line: UInt = #line)-> AnyPublisher<Date, Never>
|
ipavlidakis
force-pushed
the
performance/timer-storage-v2
branch
from
8808152 to
76ddf7d
Compare
Public Interface+ public struct DefaultTimer: Timer
+
+ public static func publish(every interval: TimeInterval,file: StaticString = #file,function: StaticString = #function,line: UInt = #line)-> AnyPublisher<Date, Never>
|
ipavlidakis
changed the title
Public Interface+ public struct DefaultTimer: Timer
+
+ public static func publish(every interval: TimeInterval,file: StaticString = #file,function: StaticString = #function,line: UInt = #line)-> AnyPublisher<Date, Never>
|
Public Interface+ public struct DefaultTimer: Timer
+
+ public static func publish(every interval: TimeInterval,file: StaticString = #file,function: StaticString = #function,line: UInt = #line)-> AnyPublisher<Date, Never>
|
martinmitrevski
approved these changes
Jun 30, 2025
| /// cancels previous subscriptions when the coordinator changes. | ||
| /// | ||
| /// - Parameter peerConnectionCoordinator: The coordinator to observe. | ||
| /// - Parameter peerConnectionCoordinator: The coordinator to observe. |
Contributor
There was a problem hiding this comment.
what happened here?
| /// | ||
| /// All scheduled timers are executed on the provided dispatch queue, which | ||
| /// allows running timers off the main thread in background contexts. | ||
| protocol Timer { |
Contributor
There was a problem hiding this comment.
Is this the same implementation we have on chat? Since both products should use the same implementation eventually, from StreamCore.
Public Interface+ public struct DefaultTimer: Timer
+
+ public static func publish(every interval: TimeInterval,file: StaticString = #file,function: StaticString = #function,line: UInt = #line)-> AnyPublisher<Date, Never>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
This revision attempts to improve performance by moving recurring Timers from the main thread to a background thread.
🛠 Implementation
We are extending the existing Timer control to:
🎨 Showcase
Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.
☑️ Contributor Checklist