-
Notifications
You must be signed in to change notification settings - Fork 39
feat(events)!: improved type narrowing on call events #1246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add video device selection button - add mic device selection button
- style documentation buttons smaller
Assign `data-testid` attributes to the Call Control Buttons.
- allow for a primary and secondary active state on the button
- remove redundant code and file
when speaker left or right is active on mobile switch to speaker bottom
Adds a new feature flag that enables General Location randomization. Once enabled, Pronto will send a randomly selected location to our backend. ### Notes On larger calls, we want to ensure that participants are assigned to random SFUs around the globe. Hopefully, this will help us detect some edge cases with Cascading.
Adds an experimental waiting room functionality in Pronto built on top of `custom` events. For more information, check: https://getstream.slack.com/archives/C022N8JNQGZ/p1706886559355909thread_ts=1706212004.817829&cid=C022N8JNQGZ
# Conflicts: # packages/react-sdk/CHANGELOG.md # yarn.lock
# Conflicts: # sample-apps/react/react-dogfood/components/MeetingUI.tsx # sample-apps/react/react-dogfood/hooks/useGleap.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Improves the type narrowing on
callevents. Event listeners used to be quite general and thus, required them to do type narrowing inside their body. With this change that is no longer necessary as now TS can narrow the type for us.Breaking Changes
EventHandler,CallEventHandler)call.stateOther important notes