Skip to content

Conversation

@martinmitrevski
Copy link
Contributor

🔗 Issue Links

Several GH issues and questions about iOS 16 support.

🎯 Goal

Fix the build issues we have on Xcode 14 beta versions.

🛠 Implementation

Lazy variables using @available are no longer supported. This is not an Xcode beta bug, but a 5.7 Swift feature: swiftlang/swift#41112.

Workaround is to use a backing storage with a computed variable. In order to avoid force unwrapping, another init is called as a fallback. If you have a better idea, please share it.

🧪 Manual Testing Notes

Channel publisher works in SwiftUI. Let's see where else we could test this.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • This change follows zero ⚠️ policy (required)
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

🎁 Meme

Alt Text

@martinmitrevski martinmitrevski requested a review from a team as a code owner July 29, 2022 10:08
Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

86.9% 86.9% Coverage
0.0% 0.0% Duplication

@martinmitrevski martinmitrevski merged commit ea16c01 into develop Jul 29, 2022
@martinmitrevski martinmitrevski deleted the fix-ios16-issues branch July 29, 2022 15:00
@hugobernalstream hugobernalstream mentioned this pull request Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants