Skip to content

fix: properly set minIndexForVisible #3136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isekovanic merged 2 commits into from
Jun 25, 2025
Merged

fix: properly set minIndexForVisible #3136

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ca5148
fix: properly calculate minIndexForVisible
isekovanic Jun 25, 2025
f036151
fix: remove console.log
isekovanic Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions package/src/components/MessageList/MessageList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,12 +335,14 @@ const MessageListWithContext = (props: MessageListPropsWithContext) => {

const [autoscrollToRecent, setAutoscrollToRecent] = useState(false);

const minIndexForVisible = Math.min(1, processedMessageList.length);

const maintainVisibleContentPosition = useMemo(
() => ({
autoscrollToTopThreshold: autoscrollToRecent ? 10 : undefined,
minIndexForVisible: 1,
minIndexForVisible,
}),
[autoscrollToRecent],
[autoscrollToRecent, minIndexForVisible],
);

/**
Expand Down Expand Up @@ -620,7 +622,7 @@ const MessageListWithContext = (props: MessageListPropsWithContext) => {
}, [threadList, messageListLengthAfterUpdate, topMessageAfterUpdate?.id]);

useEffect(() => {
if (!rawMessageList.length) {
if (!processedMessageList.length) {
return;
}
if (threadList) {
Expand All @@ -637,7 +639,7 @@ const MessageListWithContext = (props: MessageListPropsWithContext) => {
}
const latestNonCurrentMessageBeforeUpdate = latestNonCurrentMessageBeforeUpdateRef.current;
latestNonCurrentMessageBeforeUpdateRef.current = undefined;
const latestCurrentMessageAfterUpdate = rawMessageList[rawMessageList.length - 1];
const latestCurrentMessageAfterUpdate = processedMessageList[0];
if (!latestCurrentMessageAfterUpdate) {
setAutoscrollToRecent(true);
return;
Expand All @@ -662,7 +664,7 @@ const MessageListWithContext = (props: MessageListPropsWithContext) => {
}
}
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [channel, rawMessageList, threadList]);
}, [channel, processedMessageList, threadList]);

const goToMessage = useStableCallback(async (messageId: string) => {
const indexOfParentInMessageList = processedMessageList.findIndex(
Expand Down