fix: thread messages setting broken #3068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khushal87
approved these changes
Apr 29, 2025
Contributor
SDK Size
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
This is an interesting bug that we caught within smoke testing of V7.
Essentially, this has been a dormant issue in the SDK for ages; pretty much relying on the fact that our
MessageListwould rerender literally every time one of its parents rerendered (and completely rereference itsdatain the process). In that regard, this would work because of cascading state updates that happened on theChannelHoC level.Since this was fixed in one of the recent performance improvement PRs, the faulty behaviour was no longer in place and the dormant bug came to the horizon.
🛠 Implementation details
🎨 UI Changes
iOS
Android
🧪 Testing
☑️ Checklist
developbranch