Skip to content

fix: use channel.cid instead of id #2960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 19, 2025
Merged

fix: use channel.cid instead of id #2960

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b7cf14c
fix: use channel.cid instead of id
isekovanic Feb 19, 2025
8202bc1
chore: remove console.log
isekovanic Feb 19, 2025
d0759b7
chore: restructure ignored events
isekovanic Feb 19, 2025
89424d4
chore: add better explanatino
isekovanic Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions package/src/components/Channel/Channel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -766,9 +766,17 @@ const ChannelWithContext = <

const handleEvent: EventHandler<StreamChatGenerics> = (event) => {
if (shouldSyncChannel) {
// Ignore user.watching.start and user.watching.stop events
const ignorableEvents = ['user.watching.start', 'user.watching.stop'];
if (ignorableEvents.includes(event.type) || event.type.startsWith('poll.')) return;
/**
* Ignore user.watching.start and user.watching.stop as we should not copy the entire state when
* they occur. Also ignore all poll related events since they're being handled in their own
* reactive state and have no business having an effect on the Channel component.
*/
if (
event.type.startsWith('poll.') ||
event.type === 'user.watching.start' ||
event.type === 'user.watching.stop'
)
return;

// If the event is typing.start or typing.stop, set the typing state
const isTypingEvent = event.type === 'typing.start' || event.type === 'typing.stop';
Expand Down Expand Up @@ -871,7 +879,7 @@ const ChannelWithContext = <
listener?.unsubscribe();
};
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [channelId, messageId, shouldSyncChannel]);
}, [channel.cid, messageId, shouldSyncChannel]);

// subscribe to channel.deleted event
useEffect(() => {
Expand Down
Loading