Skip to content

Expo 36 support and some more stuff #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vishalnarkhede merged 11 commits into from
Dec 24, 2019
Merged

Expo 36 support and some more stuff #102

vishalnarkhede merged 11 commits into from
Dec 24, 2019

Conversation

@vishalnarkhede
Copy link
Contributor

@vishalnarkhede vishalnarkhede commented Dec 23, 2019 •
edited
Loading

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

  1. NetInfo dependency has been switched from react-native to react-native-community/netinfo - Chat not working with Expo SDK 36.0.0 due to missing NetInfo dependencies #97
    React-native-web dependencies #96
    Tested on expo-33, 34, 35, 36
  2. Bug fix for freezing UI on long press on image viewer - Longpress on attachment (image) in chat locks app in unusable state #100
  3. Bug fix for thread - Can't open thread - TypeError: undefined is not an object (evaluating 'this.props.eventHistory.none.forEach') #104
  4. Adding support for additionalFlatListProps prop in MessageList and ChannelList component (CRNS-11 from kanban)
  5. updating propTypes of Component type prop - Use PropTypes.elementType instead of PropTypes.func #39 (reference - How to best define a propType for accepting a component as a prop? facebook/react#5143 (comment))

@vishalnarkhede vishalnarkhede changed the title Vishal/expo 36 support Expo 36 support Dec 23, 2019
@vishalnarkhede vishalnarkhede changed the title Expo 36 support Expo 36 support and CRNS-43 Dec 23, 2019
vishalnarkhede
vishalnarkhede commented Dec 23, 2019
View reviewed changes
src/components/Gallery.js
// TODO: We don't have 'save image' functionality.
// Until we do, lets disable this feature. saveToLocalByLongPress prop basically
// opens up popup menu to with an option "Save to the album", which basically does nothing.
saveToLocalByLongPress={false}
Copy link
Contributor Author

@vishalnarkhede vishalnarkhede Dec 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#100

vishalnarkhede
vishalnarkhede commented Dec 23, 2019
View reviewed changes
src/components/MessageList.js
newMessages.push({
type: 'channel.event',
event: e,
this.props.eventHistory &&
Copy link
Contributor Author

@vishalnarkhede vishalnarkhede Dec 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#104

@vishalnarkhede vishalnarkhede changed the title Expo 36 support and CRNS-43 Expo 36 support and some bug fixes Dec 23, 2019
@vishalnarkhede vishalnarkhede changed the title Expo 36 support and some bug fixes Expo 36 support and some more stuff Dec 24, 2019
@vishalnarkhede vishalnarkhede merged commit 1ad78ca into master Dec 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the vishal/expo-36-support branch December 24, 2019 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tbarbugli tbarbugli Awaiting requested review from tbarbugli

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vishalnarkhede