[🐛] Getting stuck in loading state for ChannelList

[ndb-allgravy]

Issue

We're getting reports from users getting stuck on an infinite loading status on the ChannelList component.
This happens in a situation with bad connection, but with offline enabled and available data, which gets wiped.

Related code looks like in stream-chat-js, so I created issue there but posting here for visibility too.
GetStream/stream-chat-js#1584

Thank you! Let me know if this makes sense

Steps to reproduce

Steps to reproduce the behavior:

With a bad connection...

1. Offline sync manager tries to client.sync() but this fails with a timeout
2. Offline data gets deleted
3. Querying channels fails due to timeout, and isLoading is not cleared
4. See loading status, even if we a) should have offline data, and b) should instead show an error if we didn't have data

Expected behavior

• Loading state should be false when we have an error after all queryChannels requests have failed
• Offline data should not be wiped when a sync request fails.

[isekovanic]

Hi @ndb-allgravy ,

Thanks for reporting this ! Both suggestions make sense, the loading state not clearing is an obvious blunder of a bug on the side of the LLC and the sync API failing due to timeouts (and subsequently clearing the DB) is also something that should be taken into account. We'll add these changes relatively soon.

Cheers !

[ndb-allgravy]

@isekovanic that's great! It would be awesome if the fix is also shipped for version 7 of the react-native sdk 😄

Is that possible?

[khushal87]

Yes @ndb-allgravy, once its done I will backport it to v7 as well.

[ndb-allgravy]

Thank you @khushal87, really appreciate this!