fix: properly set minIndexForVisible #3136
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
This PR addresses an issue where the
MessageList's underlyingFlatListwould get caught in a weird infinite scrolling (into nothing) state whenever we removed the lastiteminside of it.This was particularly obvious on
threads, with the following reproduction steps:deletedMessagesVisibilityType={'never'}on theChannelcomponent encapsulating aThreadthreadfrom a messagemessageinto thethreadDeleted Messagedefault as we set the visibility tonever)FlatListwould now spin endlesslyThe actual issue is that the
FlatListcompletely bugs out whenever we pass it anindexit can clearly not find (since the message got deleted, the index no longer exists. Instead, we keep theminIndexForVisibleset to1for anything other than an empty list.Should also close this Github issue.
🛠 Implementation details
🎨 UI Changes
iOS
Android
🧪 Testing
☑️ Checklist
developbranch