Skip to content

fix: [CHA-826] normalize queryDrafts sort #1509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arnautov-anton merged 1 commit into from
Apr 4, 2025
Merged

fix: [CHA-826] normalize queryDrafts sort #1509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4071,6 +4071,11 @@ export class StreamChat<StreamChatGenerics extends ExtendableGenerics = DefaultG
user_id?: string;
} = {},
) {
return await this.post<QueryDraftsResponse<StreamChatGenerics>>(this.baseURL + '/drafts/query', options);
const payload = {
...options,
sort: options.sort ? normalizeQuerySort(options.sort) : undefined,
};

return await this.post<QueryDraftsResponse<StreamChatGenerics>>(this.baseURL + '/drafts/query', payload);
}
}
25 changes: 11 additions & 14 deletions src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ export type RequireOnlyOne<T, Keys extends keyof T = keyof T> = Pick<T, Exclude<
[K in Keys]-?: Required<Pick<T, K>> & Partial<Record<Exclude<Keys, K>, undefined>>;
}[Keys];

export type PartializeKeys<T, K extends keyof T> = Partial<Pick<T, K>> & Omit<T, K>;

/* Unknown Record */
export type UR = Record<string, unknown>;
export type UnknownType = UR; //alias to avoid breaking change
Expand Down Expand Up @@ -1316,6 +1318,7 @@ export type Event<StreamChatGenerics extends ExtendableGenerics = DefaultGeneric
connection_id?: string;
// event creation timestamp, format Date ISO string
created_at?: string;
draft?: DraftResponse<StreamChatGenerics>;
// id of the message that was marked as unread - all the following messages are considered unread. (notification.mark_unread)
first_unread_message_id?: string;
hard_delete?: boolean;
Expand Down Expand Up @@ -3855,7 +3858,7 @@ export type SdkIdentifier = { name: 'react' | 'react-native' | 'expo' | 'angular
*/
export type DeviceIdentifier = { os: string; model?: string };

export declare type DraftResponse<StreamChatGenerics extends ExtendableGenerics = DefaultGenerics> = {
export type DraftResponse<StreamChatGenerics extends ExtendableGenerics = DefaultGenerics> = {
channel_cid: string;
created_at: string;
message: DraftMessage<StreamChatGenerics>;
Expand All @@ -3864,30 +3867,24 @@ export declare type DraftResponse<StreamChatGenerics extends ExtendableGenerics
parent_message?: MessageResponseBase<StreamChatGenerics>;
quoted_message?: MessageResponseBase<StreamChatGenerics>;
};
export declare type CreateDraftResponse<
StreamChatGenerics extends ExtendableGenerics = DefaultGenerics
> = APIResponse & {
export type CreateDraftResponse<StreamChatGenerics extends ExtendableGenerics = DefaultGenerics> = APIResponse & {
draft: DraftResponse<StreamChatGenerics>;
};

export declare type GetDraftResponse<StreamChatGenerics extends ExtendableGenerics = DefaultGenerics> = APIResponse & {
export type GetDraftResponse<StreamChatGenerics extends ExtendableGenerics = DefaultGenerics> = APIResponse & {
draft: DraftResponse<StreamChatGenerics>;
};

export declare type QueryDraftsResponse<
StreamChatGenerics extends ExtendableGenerics = DefaultGenerics
> = APIResponse & {
export type QueryDraftsResponse<StreamChatGenerics extends ExtendableGenerics = DefaultGenerics> = APIResponse & {
drafts: DraftResponse<StreamChatGenerics>[];
next?: string;
};
} & Omit<Pager, 'limit'>;

export declare type DraftMessagePayload<StreamChatGenerics extends ExtendableGenerics = DefaultGenerics> = Omit<
export type DraftMessagePayload<StreamChatGenerics extends ExtendableGenerics = DefaultGenerics> = PartializeKeys<
DraftMessage<StreamChatGenerics>,
'id'
> &
Partial<Pick<DraftMessage<StreamChatGenerics>, 'id'>>;
> & { user_id?: string };

export declare type DraftMessage<StreamChatGenerics extends ExtendableGenerics = DefaultGenerics> = {
export type DraftMessage<StreamChatGenerics extends ExtendableGenerics = DefaultGenerics> = {
id: string;
text: string;
attachments?: Attachment<StreamChatGenerics>[];
Expand Down