fix: multiple module augmentation fails in Angular#1488
Merged
Conversation
szuperaz
requested review from
MartinCupela,
arnautov-anton,
khushal87,
myandrienko,
oliverlaz,
santhoshvai and
vishalnarkhede
as code owners
Contributor
|
Size Change: 0 B Total Size: 290 kB ℹ️ View Unchanged
|
szuperaz
force-pushed
the
fix-module-augmentation-issue
branch
from
17c44a7 to
43a7907
Compare
szuperaz
force-pushed
the
fix-module-augmentation-issue
branch
from
43a7907 to
110e9f3
Compare
arnautov-anton
approved these changes
Mar 5, 2025
github-actions Bot
pushed a commit
that referenced
this pull request
Mar 5, 2025
## [9.0.0-rc.5](v9.0.0-rc.4...v9.0.0-rc.5) (2025-03-05) ### Bug Fixes * multiple module augmentation fails in Angular ([#1488](#1488)) ([7f8a9a0](7f8a9a0))
|
🎉 This PR is included in version 9.0.0-rc.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions Bot
pushed a commit
that referenced
this pull request
May 6, 2025
## [9.0.0](v8.60.0...v9.0.0) (2025-05-06) ### ⚠ BREAKING CHANGES * Replacement of FormatMessageResponse with LocalMessage type * `ErrorFromResponse` class constructor now requires second parameter (`status`, `response` and optionally `code`) * dropped jsDelivr bundle (#1468) * dropped `StreamChatGenerics`, use `Custom<Entity>Data` to extend your types * type `InviteOptions` has been renamed to `UpdateChannelOptions` * type `UpdateChannelOptions` has been renamed to `UpdateChannelTypeRequest` * type `ThreadResponseCustomData` has been renamed to `CustomThreadData` * type `MarkAllReadOptions` has been deleted in favour of type `MarkChannelsReadOptions` * type `QueryFilter` no longer supports `$ne` and `$nin` operators * type `ChannelMembership` has been deleted in favour of type `ChannelMemberResponse` * function `formatMessage` (`utils.ts`) no longer returns `__html` property in the formatted message output ### Bug Fixes * [REACT-344] remove Agora & 100ms integrations ([#1519](#1519)) ([16cd81a](16cd81a)) * add image property to UserResponse type ([#1486](#1486)) ([2a57b7f](2a57b7f)) * adjust ChannelResponse, ChannelData & PollResponse ([#1493](#1493)) ([39091c7](39091c7)) * adjust ErrorFromResponse error class ([#1491](#1491)) ([ff32bd2](ff32bd2)) * increase package.json[engines.node] version ([6764bad](6764bad)) * multiple module augmentation fails in Angular ([#1488](#1488)) ([7f8a9a0](7f8a9a0)) * omit name from CustomChannelData for ChannelFilters ([#1494](#1494)) ([d7030c2](d7030c2)) * **qa:** adjust Event & ChannelData types ([#1524](#1524)) ([f1d73fd](f1d73fd)) * remove message composer bugs ([#1521](#1521)) ([8b324eb](8b324eb)) * replace StreamChatGenerics with module augmentation ([#1458](#1458)) ([feb97da](feb97da)) ### Features * add missing configuration parameters for AttachmentManager and TextComposer ([#1520](#1520)) ([44902e7](44902e7)) * disable link previews in message composer ([02cd9a8](02cd9a8)) * improve MessageComposer ergonomics ([2c0c639](2c0c639)) * make MessageComposer middleware executors public ([9aae032](9aae032)) * message composer ([#1495](#1495)) ([0c07524](0c07524)), closes [stream-chat-react#2669](GetStream/stream-chat-react#2669) * middleware handler API improvement ([#1523](#1523)) ([9d8992d](9d8992d))
|
🎉 This PR is included in version 9.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLA
Description of the changes, What, Why and How?
When removing generics from stream-chat-angular I had an issue where augmenting the same custom interface (for example
CustomChannelData) from two places (SDK and sample app) some changes were ignored (detailed description: https://getstream.slack.com/archives/C06CF5TKRGA/p1741163343794659).Found this open GH issue for TypeScript: microsoft/TypeScript#46617
https://linear.app/stream/issue/ANG-31/drop-generics
Changelog