fix: set loading state to false when query channel errors out#1585
Merged
fix: set loading state to false when query channel errors out#1585
Conversation
khushal87
requested review from
MartinCupela,
arnautov-anton,
myandrienko,
oliverlaz,
santhoshvai,
szuperaz and
vishalnarkhede
as code owners
Contributor
|
Size Change: +406 B (+0.09%) Total Size: 442 kB
|
isekovanic
requested changes
Jul 29, 2025
Contributor
isekovanic
left a comment
isekovanic
left a comment
There was a problem hiding this comment.
Looks good to me ! Please write tests for this
…manager for offline case
…manager for offline case
isekovanic
reviewed
Jul 30, 2025
| expect(upsertUserSyncStatusSpy).toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| it('do not resets DB if sync API throws an AxiosError with request timeout', async () => { |
Contributor
There was a problem hiding this comment.
totally not important nitpick
Suggested change
| it('do not resets DB if sync API throws an AxiosError with request timeout', async () => { | |
| it('do not reset the DB if the sync API throws an AxiosError with request timeout', async () => { |
isekovanic
reviewed
Jul 30, 2025
| expect(resetDBSpy).not.toHaveBeenCalled(); | ||
| expect(upsertUserSyncStatusSpy).not.toHaveBeenCalled(); | ||
| }); | ||
|
|
Contributor
There was a problem hiding this comment.
In the test just below this one, please add an additional check for the channelManager.state.isLoading value (it should now be false with the recent fixes)
isekovanic
approved these changes
Jul 30, 2025
Contributor
isekovanic
left a comment
isekovanic
left a comment
There was a problem hiding this comment.
Please add the oneliner check that I mentioned in my comment and then you can feel free to merge this. Thanks !
|
🎉 This PR is included in version 9.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR focuses on the following:
Closes #1584 GetStream/stream-chat-react-native#3180