Conversation
inform dialogs depend on the main window, which might not be available (e.g. new account window. Toasts are signal based.
index_of_char should be faster (haven't benchmarked) for one char needles. 'user' is too generic, should only look it up if it's a path child prefix
Hashtag urls are non-resolvable so they need manual parsing. Previously, it could lead to non-fedi urls getting parsed, if they had a /tags/ path child. Now it checks if the url ends in /tags/<url>. Some backends may add query params or fragments that he had to manually strip. Now it uses GLib.Uri that does the parsing for us. Future commits will optimize RichLabel, Host and Tracking to use the same GLib.Uri instance instead of creating multiple ones.
if backend allow web+ap urls, tuba will open them in-app now. E.g. web+ap://.../[at]Tuba, will now open in-app instantly, instead of asking your OS to pick an app to open it with.
Vala doesn't support unions, so two methods are needed. open_url accepts strings, open_uri accepts GLib.Uri.
Owner
Author
|
Terrible Utils.Host API names |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
web+ap://faraway.town/@GeopJrwill open my profile in-app instead of going through the process of asking your OS to open the default app forweb+apuris)