Merged
Conversation
Contributor
|
Whoa, that's a cool feature, I have no idea Mastodon is doing this. I like it a lot <3 Tiny suggestion: can posts in this summary be clickable so we can see the whole threads? |
Owner
Author
|
Sounds good! My main issue was that since it's a dialog, you cannot really access the main window but maybe we should just close the dialog when a post is clicked and the thread opens |
due to the css animation the paintable content is being invalidated constantly, so when it's time to take a screenshot, the new frame might not have been drawn and we will get an empty snapshot back. Instead create the widget paintable on construct and use it when we need to take a screenshot
same as aboutdialog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mastodon/mastodon#32709
In general, I align with Claire on the data being mostly popularity based. While Tuba will display most of it, I decided to not include them in the exportables. I also decided to ignore the archetype and percentiles. Archetype is mostly Mastodon brand related and percentiles is purely popularity score lol
Łukasz if you happen to see this and want to test it out, enable
dev_modein meson, F2, and paste the following in the last field:that is fake data, don't post any of the exportables or screenshots of them yet! Let's keep it a surprise :)
TODO: