Merged
Conversation
Also adds a temporary manifest that's required for this to build. When Tuba switches to the GNOME 48 runtime in the future, the temp manifest can be dropped.
Owner
|
Thanks! I'll revisit this in... 6 months! 😆 |
Contributor
Author
|
haha, just performing some early field testing :) |
Owner
|
LGTM, thanks!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In GNOME 48, libadwaita will ship with a new, cool feature that allows developers to show off their other projects in the about window of the app. This is an initial implementation of that in Tuba.
Currently it requires a custom manifest to build due to some ongoing difficulties with abstract Vala interfaces / the GNOME master runtime, but that can be dropped before merging this when the GNOME 48 runtime becomes available.
Whether you want this or not is of course also up to you, there can be a lot of reasons not to 🙂