Add ru lang to android app, fix disconnect in android app#169
Add ru lang to android app, fix disconnect in android app#169mksmbrtsh wants to merge 6 commits intoGenymobile:masterfrom
Conversation
mksmbrtsh
commented
Jan 31, 2019
mksmbrtsh
commented
- fix bug with system vpn dialog (click to disconnect, not full stop android app)
- fix not full stop android app if android device unplug USB
- remove disconnect notify in android app
- add translate to ru to android app
* fix bug with system vpn dialog (click to disconnect, not full stop android app) * fix not full stop android app if android device unplug USB - remove disconnect notify in android app + add translate to ru to android app
rom1v
left a comment
rom1v
left a comment
There was a problem hiding this comment.
Thank you for your contribution.
Could you provide 1 commit per change (even 1 PR per change if possible, so they can be merged independently), please?
| Log.w(TAG, "Cannot close VPN file descriptor", e); | ||
| } | ||
| stopSelf(); | ||
| } |
There was a problem hiding this comment.
Wouldn't it be possible to just call close()?
There was a problem hiding this comment.
stopSelf() - method from android api, iron destroy service.
I put close() method, service not stop immedly.
| <resources> | ||
| <string name="app_name" translatable="false">Gnirehtet</string> | ||
| <string name="relay_connected">Reverse tethering enabled</string> | ||
| <string name="relay_disconnected">Disconnected from the relay server</string> |
There was a problem hiding this comment.
I would like the close-on-disconnect behavior in addition to the current behavior (via a command-line option). See #51
There was a problem hiding this comment.
Oh, dude dont find this thread. Think, when device disconnected from relay server, out service and notif only angry users (my users). Notif can not close.
Sorry my english, bro, i from russian,
There was a problem hiding this comment.
A -k option to keep the current behavior would be perfect :)
There was a problem hiding this comment.
I can work on this option when I have some time, if you prefer.
| startGnirehtet(context, config); | ||
| } else if (ACTION_GNIREHTET_STOP.equals(action)) { | ||
| stopGnirehtet(context); | ||
| } else if ("android.hardware.usb.action.USB_STATE".equals(action)){ |
There was a problem hiding this comment.
IMO, it should rely on whether the socket is connected or not, whatever the USB state is (the socket can be disconnected while the USB cable is still connected).
There was a problem hiding this comment.
Oh, i not replace intent "ACTION_GNIREHTET_STOP"("socket can be disconnected while the USB cable is still connected"), i add intent USB_STATE with disconnected (if cabel unplug, then socket dont work too).
There was a problem hiding this comment.
It should not rely on USB state, but on the socket connection state.
|
You right, but add ru lang only 3 strings, i think this very small change. |
Each independent change should be in separate commit, so that they can be merged, rebased, reverted, bisected… independently. 😉 |
|
Hello, enjoyed your program version of the 2.1 ! the program has changed in Android Studio! added activiti with input fields IP and DNS, the Program worked badly, constantly stops. My change works well! IP which I enter the interface on Android as a result of check of WebRTC show the IP necessary to me. Please add a menu to gnirehtet.APK-enter the IP address of the interface to connect and preferably enter DNS! Thanks. |
3 participants
