Skip to content

Change images names #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PaulWessel merged 8 commits into from
Oct 13, 2023
Merged

Change images names #89

PaulWessel merged 8 commits into from
Oct 13, 2023

Conversation

@Esteban82
Copy link
Member

@Esteban82 Esteban82 commented Oct 13, 2023

This PR is only for changing the name of the maps. They now use the name corresponding to the grid from which they originate.

@Esteban82 Esteban82 requested a review from PaulWessel October 13, 2023 12:20
@Esteban82 Esteban82 self-assigned this Oct 13, 2023
@Esteban82 Esteban82 requested a review from a team October 13, 2023 12:20
@seisman
Copy link
Member

seisman commented Oct 13, 2023

Instead of GMT_relief.jpg, I think we should use GMT_earth_relief.jpg, as we will have more datasets like moon_relief.

@Esteban82
Copy link
Member Author

Esteban82 commented Oct 13, 2023

Instead of GMT_relief.jpg, I think we should use GMT_earth_relief.jpg, as we will have more datasets like moon_relief.

Well, in this case, all maps should start with GMT_earth_.

@PaulWessel
Copy link
Member

PaulWessel commented Oct 13, 2023

I agree with @seisman here. Simpler to do GMT_.jpg, no?

@Esteban82
Copy link
Member Author

Esteban82 commented Oct 13, 2023

Ok. I will update the names.

@Esteban82
Copy link
Member Author

Esteban82 commented Oct 13, 2023

I just rename all the figures. Ready to be approved.

@Esteban82
Copy link
Member Author

Esteban82 commented Oct 13, 2023

I should also modify the scripts and the readme. But I prefer to do it in another PR.

@Esteban82 Esteban82 added the documentation Improvements or additions to documentation label Oct 13, 2023
@Esteban82
Copy link
Member Author

Esteban82 commented Oct 13, 2023

When this PR is approved and merge, I will make another one for #88.

@PaulWessel PaulWessel merged commit 8bc9c4d into main Oct 13, 2023
@PaulWessel PaulWessel deleted the change_names branch October 13, 2023 21:40
@seisman seisman mentioned this pull request Oct 14, 2023
Merged
7 tasks
@yvonnefroehlich yvonnefroehlich mentioned this pull request Oct 14, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PaulWessel PaulWessel PaulWessel approved these changes

Assignees

@Esteban82 Esteban82

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Esteban82 @seisman @PaulWessel