Revert the migration from Vercel App to Vercel action #973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiji14
approved these changes
Feb 26, 2021
Member
There was a problem hiding this comment.
TODO:
- Put skip-changelog tags on this PR, as well as #964
- Reinstall Vercel Github App
- Remove Vercel secrets at https://github.com/GenericMappingTools/pygmt/settings/secrets/actions
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…Tools#973) * Revert "Disable pull_request_target for the vercel action (GenericMappingTools#969)" This reverts commit f455c31. * Revert "Use Vercel action for continuous documentation (GenericMappingTools#964)" This reverts commit 17133d1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Vercel action doesn't work well for PRs from forks (see https://github.com/GenericMappingTools/pygmt/pull/804/checks?check_run_id=1985450405 for an example run), because PRs from forks cannot access our tokens.
There may be some workaround (https://securitylab.github.com/research/github-actions-preventing-pwn-requests), but it seems complicated.
We may have to go back to Vercel App again.