Skip to content

Speedup the Continuous Documentation using mamba #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
seisman merged 7 commits into from
Jan 30, 2021
Merged

Speedup the Continuous Documentation using mamba #813

seisman merged 7 commits into from
Jan 30, 2021

Conversation

@seisman
Copy link
Member

@seisman seisman commented Jan 28, 2021 •
edited
Loading

Description of proposed changes

gmt is already listed as a dependency in environment.yml,
so running conda env create -f environment.yml already has gmt
installed. No need to install gmt again.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Notes

  • You can write /format in the first line of a comment to lint the code automatically

@seisman
Simplify the vercel build commands
5d7851d 
`gmt` is already listed as a dependency in
[environment.yml](https://github.com/GenericMappingTools/pygmt/blob/master/environment.yml),
so running `conda env create -f environment.yml` already has `gmt`
installed. No need to install `gmt` again.
@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Jan 28, 2021
@seisman seisman added this to the 0.3.0 milestone Jan 28, 2021
@seisman seisman requested a review from weiji14 January 28, 2021 23:28
weiji14
weiji14 reviewed Jan 29, 2021
View reviewed changes
@seisman seisman mentioned this pull request Jan 29, 2021
Closed
5 tasks
@seisman
Copy link
Member Author

seisman commented Jan 29, 2021

Tried mamba in commit d426c57. The building time is 5.5 minutes, compared to ~7 minutes using miniconda. micromamba (#817) has a similar building time (~6 minutes).

@weiji14
Copy link
Member

weiji14 commented Jan 29, 2021

Tried mamba in commit d426c57. The building time is 5.5 minutes, compared to ~7 minutes using miniconda. micromamba (#817) has a similar building time (~6 minutes).

What do you think? Close this in favour of #817? A minute saved over hundreds of CI builds with each PR commit is still a lot!

@seisman
Copy link
Member Author

seisman commented Jan 29, 2021

micromamba in #817 is still experimental. I prefer this PR.

weiji14
weiji14 approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, using conda install mamba does seem cleaner here than installing micromamba in #817. I would close #817 once this PR is merged.

P.S. Please change the PR title to mention mamba.

@seisman seisman changed the title Simplify the vercel build commands Speedup the Continuous Documentation using mamba Jan 29, 2021
@seisman seisman merged commit 7c35bb0 into master Jan 30, 2021
@seisman seisman deleted the vercel branch January 30, 2021 02:02
@weiji14 weiji14 mentioned this pull request Feb 6, 2021
Merged
5 tasks
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@seisman @weiji14
Speedup the Continuous Documentation using mamba (GenericMappingTools…
a59c34f 
…#813)

* Simplify the vercel build commands

`gmt` is already listed as a dependency in
[environment.yml](https://github.com/GenericMappingTools/pygmt/blob/master/environment.yml),
so running `conda env create -f environment.yml` already has `gmt`
installed. No need to install `gmt` again.

* Use mamba

Co-authored-by: Wei Ji <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weiji14 weiji14 weiji14 approved these changes

Assignees

No one assigned

Labels

maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Milestone

0.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@seisman @weiji14