Refactor clib back into a single class #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leouieda
force-pushed
the
refactor-clib
branch
from
a6b28b6 to
79e869f
Compare
It really doesn't make sense to have them separate and pass around libgmt all the time. Just makes the whole thing more complicated.
Simplifies the code and removes duplication of docstrings.
leouieda
force-pushed
the
refactor-clib
branch
from
b8b36ae to
ed6e623
Compare
It's ignoring the setup.cfg for some reason
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It really doesn't make sense to have them separate and pass around
libgmt all the time. Just makes the whole thing more complicated.
This simplifies the code and removes duplication of docstrings.