Skip to content

Conversation

@weiji14
Copy link
Member

@weiji14 weiji14 commented Jul 10, 2020

Description of proposed changes

Patches some problems with #475 related to cache behaviour.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

@weiji14 weiji14 added the skip-changelog Skip adding Pull Request to changelog label Jul 10, 2020
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weiji14 weiji14 merged commit c9afb04 into master Jul 10, 2020
@weiji14 weiji14 deleted the patch_gh_actions branch July 10, 2020 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants